-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: mark --verbose
as deprecated
#1558
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
- Coverage 84.07% 84.05% -0.02%
==========================================
Files 119 119
Lines 5325 5331 +6
==========================================
+ Hits 4477 4481 +4
- Misses 602 604 +2
Partials 246 246 ☔ View full report in Codecov by Sentry. |
Maybe mark it deprecated in the Printer object too |
Currently it is still functioning, we can consider removing the whole verbose stuff in v1.4.0 or something? |
c36f837
to
b179510
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TerryHowe This is now ready for review. |
4680d74
to
654d68c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples align with the spec and look good to me. Thanks @Wwwsylvia
@TerryHowe would you mind taking a look at this PR? |
adb16ec
to
ddcf411
Compare
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
7ac5d4a
to
e171d73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
--verbose
flag as deprecated and print verbose output by default for the following six commands. As a result, the--verbose
flag will be hidden in the help doc, and there will be a warning message when--verbose
is specified.oras push
oras pull
oras attach
oras cp
oras manifest push
oras blob push
The deprecation of
--verbose
fororas discover
will be addressed with #1534.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1533
Prerequisite: #1553
Examples:
oras pull
BEFORE:oras pull
AFTER:oras pull --verbose
BEFORE:oras pull --verbose
AFTER:oras pull --verbose=false
BEFORE:oras pull --verbose=false
AFTER:oras pull --help
BEFORE:oras pull --help
AFTER:Please check the following list: