Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(POC): otelcol httpcheck receiver - use tags as metrics labels #2881

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Dec 18, 2023

To allow using tags in the httpcheck receiver targets as metrics labels and be able to query metrics by common tags.

Example target definition:

{
  "endpoint": "https://orb.community",
  "method": "GET",
  "tags": {
    "tag_a": "valueA",
    "tab_b": "valueB"
}

Main issue with this is if the policy having httpcheck target with tags is being used with older orb agent not having policy sanitization, it will end up with validation error on otelcol and ending up policy not being applied.

Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (0a20a09) 48.54% compared to head (8dec896) 4.73%.

Files Patch % Lines
agent/otel/otlpmqttexporter/otlp.go 8.19% 56 Missing ⚠️
agent/backend/otel/otel.go 0.00% 11 Missing ⚠️
agent/backend/otel/policy.go 57.69% 11 Missing ⚠️
agent/otel/otlpmqttexporter/factory.go 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #2881       +/-   ##
===========================================
- Coverage    48.54%   4.73%   -43.81%     
===========================================
  Files           85      15       -70     
  Lines         6339    1141     -5198     
===========================================
- Hits          3077      54     -3023     
+ Misses        3262    1087     -2175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfiedorowicz mfiedorowicz changed the title feat: otelcol httpcheck receiver - use tags as metrics labels feat(POC): otelcol httpcheck receiver - use tags as metrics labels Dec 18, 2023
@mfiedorowicz mfiedorowicz marked this pull request as draft December 19, 2023 09:56
@lpegoraro lpegoraro self-requested a review January 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants