-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(POC): otelcol httpcheck receiver - use tags as metrics labels #2881
Draft
mfiedorowicz
wants to merge
13
commits into
develop
Choose a base branch
from
feat-otelcol-httpcheck-tags-as-labels
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
lpegoraro
reviewed
Dec 18, 2023
Signed-off-by: Michal Fiedorowicz <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2881 +/- ##
===========================================
- Coverage 48.54% 4.73% -43.81%
===========================================
Files 85 15 -70
Lines 6339 1141 -5198
===========================================
- Hits 3077 54 -3023
+ Misses 3262 1087 -2175 ☔ View full report in Codecov by Sentry. |
mfiedorowicz
changed the title
feat: otelcol httpcheck receiver - use tags as metrics labels
feat(POC): otelcol httpcheck receiver - use tags as metrics labels
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow using
tags
in the httpcheck receiver targets as metrics labels and be able to query metrics by common tags.Example target definition:
Main issue with this is if the policy having httpcheck target with
tags
is being used with older orb agent not having policy sanitization, it will end up with validation error on otelcol and ending up policy not being applied.