Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for solana v2 crates to rust client #726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for solana v2 crates to rust client #726

wants to merge 1 commit into from

Conversation

wjthieme
Copy link
Member

@wjthieme wjthieme commented Feb 6, 2025 •
edited
Loading

Since this is a breaking change, I will bump the major version of the orca_whirlpools_client crate. This version is still backwards compatible with solana v1 crates but the consumer will need to enable the solana-v1 feature.

Theoretically I could have also done non-breaking:

  • Use a solana-v2 feature that a user explicitly needs to enable. Imo this makes it more difficult down the line to make solana v2 the default/recommended
  • Add solana-v1 to the default features. This would be non-breaking but would just add the breaking-change and major version bump for a later date. This would make the consumers cargo.toml less clean as having to disable the default features is less nice than having to enable a feature

@wjthieme wjthieme self-assigned this Feb 6, 2025
yugure-orca
yugure-orca approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@yugure-orca yugure-orca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

+1 for solana-v1 feature and the default is v2.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 7, 2025
View reviewed changes
rust-sdk/integration/index.test.ts Dismissed Show dismissed Hide dismissed
@wjthieme
Squashed commit of the following:
bb778c4 
commit 7c0ed0a
Author: Wilhelm Thieme <[email protected]>
Date:   Tue Feb 11 14:58:03 2025 -0500

    Lint

commit b0e3949
Merge: 1d5f82f c29eed4
Author: Will <[email protected]>
Date:   Tue Feb 11 14:51:16 2025 -0500

    Merge branch 'main' into wjthieme/client-solana-v2

commit 1d5f82f
Author: Will <[email protected]>
Date:   Tue Feb 11 14:49:45 2025 -0500

    Update action.yml

commit 55311ec
Merge: 6c2b8a1 a2bf808
Author: Will <[email protected]>
Date:   Mon Feb 10 16:30:54 2025 -0500

    Merge branch 'main' into wjthieme/client-solana-v2

commit 6c2b8a1
Author: Wilhelm Thieme <[email protected]>
Date:   Sat Feb 8 14:15:29 2025 -0500

    Tweaks?

commit df24a19
Author: Wilhelm Thieme <[email protected]>
Date:   Fri Feb 7 17:26:02 2025 -0500

    Upgrade rustc

commit f584b2b
Author: Wilhelm Thieme <[email protected]>
Date:   Fri Feb 7 16:42:31 2025 -0500

    Build fix

commit eab285e
Author: Wilhelm Thieme <[email protected]>
Date:   Fri Feb 7 16:21:48 2025 -0500

    Fix changeset

commit 38a22a8
Author: Wilhelm Thieme <[email protected]>
Date:   Fri Feb 7 16:19:52 2025 -0500

    Build fix

commit c6e2edb
Author: Wilhelm Thieme <[email protected]>
Date:   Fri Feb 7 15:16:30 2025 -0500

    fmt

commit 43e0192
Author: Wilhelm Thieme <[email protected]>
Date:   Fri Feb 7 13:34:13 2025 -0500

    Tweaks

commit 85ef1e2
Author: Wilhelm Thieme <[email protected]>
Date:   Fri Feb 7 13:26:46 2025 -0500

    Changeset

commit 78e301d
Author: Wilhelm Thieme <[email protected]>
Date:   Thu Feb 6 09:50:18 2025 -0500

    Build fix

commit 38df812
Author: Wilhelm Thieme <[email protected]>
Date:   Thu Feb 6 09:31:08 2025 -0500

    Add support for solana v2 crates to rust client
@wjthieme wjthieme force-pushed the wjthieme/client-solana-v2 branch from 7c0ed0a to bb778c4 Compare February 11, 2025 20:32
@ara-selini
Copy link

Hey folks, is there an update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yugure-orca yugure-orca yugure-orca approved these changes

@odcheung odcheung Awaiting requested review from odcheung odcheung is a code owner

@philcchen philcchen Awaiting requested review from philcchen philcchen is a code owner

@rawfalafel rawfalafel Awaiting requested review from rawfalafel rawfalafel is a code owner

Assignees

@wjthieme wjthieme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjthieme @ara-selini @yugure-orca