[1.x] Supports PHP 8.4 (#14)

* Supports PHP 8.4 Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> --------- Signed-off-by: Mior Muhammad Zaki <[email protected]>
orchestral · Sep 9, 2024 · c59cfc8 · c59cfc8
1 parent a796a66
commit c59cfc8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -19,6 +19,7 @@ jobs:
           - 8.1
           - 8.2
           - 8.3
+          - 8.4
         dependencies:
           - "highest"
           - "lowest"

diff --git a/src/Concerns/DetectsChromeVersion.php b/src/Concerns/DetectsChromeVersion.php
@@ -121,6 +121,7 @@ protected function installedChromeVersion(string $operatingSystem, ?string $dire
                 continue;
             }
 
+            /** @var array{0: string, 1: string, 2: string, 3: string} $matches */
             $semver = implode('.', [$matches[1], $matches[2], $matches[3]]);
 
             return [
@@ -163,6 +164,7 @@ protected function installedChromeDriverVersion(string $operatingSystem, string
             preg_match('/ChromeDriver\s(\d+)\.(\d+)\.(\d+)(\.\d+)?\s[\w\D]+/', $process->getOutput(), $matches);
 
             if (isset($matches[1])) {
+                /** @var array{0: string, 1: string, 2: string, 3: string} $matches */
                 $semver = implode('.', [$matches[1], $matches[2], $matches[3]]);
 
                 return [
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,6 +19,7 @@ jobs: @@
               - 8.1
               - 8.2
               - 8.3
+              - 8.4
             dependencies:
               - "highest"
               - "lowest"
@@ Expand Down @@