Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patch): Log less when --no-progress (again) #287

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

MahdiBM
Copy link
Contributor

@MahdiBM MahdiBM commented Oct 6, 2024

Description

The last PR made it so it requires the --quiet flag to silence those logs.
This wasn't my intention, I wanted --no-progress to do that.
Using --quiet will make the benchmark comparison not report what regressed if anything has regressed, so I don't want to use that flag.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@hassila hassila merged commit f9dcf0b into ordo-one:main Oct 6, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants