Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update readme to fix broken example benchmark #299

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

lehtihet
Copy link
Contributor

Description

Updates readme to fix the broken benchmark example, fixes #295 which contains more information.

How Has This Been Tested?

Tested running the benchmark from an empty project.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.44%. Comparing base (baa4ff2) to head (df565c3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   71.44%   71.44%           
=======================================
  Files          32       32           
  Lines        3788     3788           
=======================================
  Hits         2706     2706           
  Misses       1082     1082           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa4ff2...df565c3. Read the comment docs.

Copy link
Contributor

@lehtihet lehtihet changed the title Update readme to fix broken example benchmark. Fixes #295 docs: Update readme to fix broken example benchmark Nov 12, 2024
@hassila hassila self-requested a review November 18, 2024 08:59
@hassila hassila merged commit 9599dac into main Nov 18, 2024
13 of 16 checks passed
@hassila hassila deleted the issue/295 branch November 18, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Sample benchmark from Readme doesn't compile
2 participants