Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix test compilation on Ubuntu Noble #300

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

freef4ll
Copy link
Contributor

Description

Fix test build failure

Tests/BenchmarkTests/OperatingSystemAndMallocTests.swift:111:29: error: value of optional type 'UnsafeMutablePointer<FILE>?' (aka 'Optional<UnsafeMutablePointer<_IO_FILE>>') must be unwrapped to a value of type 'UnsafeMutablePointer<FILE>' (aka 'UnsafeMutablePointer<_IO_FILE>')
109 |         XCTAssertNotNil(tempFile, "tmpfile() failed: \(errno)")
110 | 
111 |         let fildes = fileno(tempFile)
    |                             |- error: value of optional type 'UnsafeMutablePointer<FILE>?' (aka 'Optional<UnsafeMutablePointer<_IO_FILE>>') must be unwrapped to a value of type 'UnsafeMutablePointer<FILE>' (aka 'UnsafeMutablePointer<_IO_FILE>')
    |                             |- note: coalesce using '??' to provide a default when the optional value contains 'nil'
    |                             `- note: force-unwrap using '!' to abort execution if the optional value contains 'nil'
112 | 
113 |         var stat = stat()

@freef4ll freef4ll requested a review from hassila November 15, 2024 15:35
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.41%. Comparing base (baa4ff2) to head (fb55887).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...BenchmarkTests/OperatingSystemAndMallocTests.swift 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   71.44%   71.41%   -0.03%     
==========================================
  Files          32       32              
  Lines        3788     3791       +3     
==========================================
+ Hits         2706     2707       +1     
- Misses       1082     1084       +2     
Files with missing lines Coverage Δ
...BenchmarkTests/OperatingSystemAndMallocTests.swift 98.39% <50.00%> (-1.61%) ⬇️
Files with missing lines Coverage Δ
...BenchmarkTests/OperatingSystemAndMallocTests.swift 98.39% <50.00%> (-1.61%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa4ff2...fb55887. Read the comment docs.

Copy link
Contributor

@freef4ll freef4ll changed the title Fix test compilation on Ubuntu Noble chore: Fix test compilation on Ubuntu Noble Nov 15, 2024
@freef4ll freef4ll merged commit 87b08bf into main Nov 15, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants