surface errors in RPC methods #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…398dd327343c6f181bf1a9bd04dd
Developer -> master
1. Adds auth middleware to most endpoints 2. Allows import without auth 3. Creates endpoint for storing tokens for legacy accounts on migrate
Adding 404 not found handler
…account-sql-statement sql statement bug fix
jowparks
force-pushed
the
oreowallet-error-surface
branch
from
60be90a to
f465725
Compare
jowparks
force-pushed
the
oreowallet-error-surface
branch
from
c53ee3a to
0708e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a few places in
servercrate there are errors being swallowed which can cause unexpected behavior. This causes the handlers to return errors if there is an error during the processing of endpoint.One example of an error I encountered when debugging:
shared.rpc_handler.set_account_head(message)was failingshared.rpc_handler.set_scanning(RpcSetScanningRequest { account: account.name.clone(), enabled: true, })was then executedNode then scanned entire account.