Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for list of complex numbers for serializing in fjagepy #319

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Add support for list of complex numbers for serializing in fjagepy #319

merged 1 commit into from
Jul 27, 2024

Conversation

notthetup
Copy link
Collaborator

@notthetup notthetup commented Jul 24, 2024 •
edited
Loading

As per the Gateway spec

Custom JSON fields

  • Must add a boolean true field with a suffix __isComplex if the message contains any arrays of complex numbers. For example, if a field signal is a complex array, a field signal__isComplex = true is added to the JSON message. This is only applicable for languages that support complex numbers natively.

We currently do this in fjagepy for numpy array. Adding similar support for python list of complex types.

@notthetup notthetup self-assigned this Jul 24, 2024
@notthetup notthetup requested a review from mchitre July 24, 2024 04:36
@notthetup notthetup mentioned this pull request Jul 24, 2024
Open
2 tasks
@notthetup notthetup merged commit 0c47203 into master Jul 27, 2024
2 checks passed
@notthetup notthetup deleted the fjagepy-complex branch July 27, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchitre mchitre mchitre approved these changes

Assignees

@notthetup notthetup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notthetup @mchitre