Feat/customize notification led color #407
Open
+131
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notification channels with new LED settings will be created. Existing notification channels won't be deleted because it would remove ongoing notifications. LED color to be specified in hex. Added basic check for hex value of color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a solution for setting custom LED colors for notifications.
Default value is set to blue to avoid any changes for existing users.
To reduce dependencies to external libraries, the color can only be defined as hex-value string not by any other sophisticated color-chooser widget.
First Kotlin PR, so please feel free to point out even slight issues. Thanks.