Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Drive Integration #931

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

sjhuang26
Copy link

This PR builds off of #867.

It is currently WIP.

@ngharrison
Copy link

@sjhuang26 Did you learn anything from working on this? I'm taking a look at it again. Maybe we can finally make it work.

@sjhuang26
Copy link
Author

@ngharrison I haven't been working on it in a while since I noticed that there's no activity from the maintainer on several other open PRs. If you want to work on the PR, you can rebase my commits (might want to rename them with more descriptive names), and here are some tips:

  • Authentication should be working.
  • I tried to make the Google Drive and Dropbox implementations as close as possible in the code structure (methods in the same order).
  • I'm not sure about this, but I think Dropbox is synchronous while Google Drive forces you to be async (it won't let you run I/O on the main thread). So if the code assumes that I/O is synchronous, this would require refactoring.
  • We need to change the path logic. The app only has permission from Google Drive to view/edit directories and files created by the app. (Getting a broader permission requires manual app approval from Google.) Given this:
    • I made a button for the user to create a new directory in the root of My Drive, which the app would own.
    • The user can move this directory, so suppose that the user puts it in /x/y/z/app_directory/.
    • Enumerating / will yield no results, so the current path logic won't work.
    • I think we should let the user enter directory ID or directory name. Then, we enumerate every directory to find it. Another approach is to have the app enumerate the directories it can see and have the user pick one in a drop-down list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants