Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple domains don't work on in helm chart #53

Open
btrepp opened this issue Sep 22, 2021 · 3 comments
Open

Multiple domains don't work on in helm chart #53

btrepp opened this issue Sep 22, 2021 · 3 comments

Comments

@btrepp
Copy link

btrepp commented Sep 22, 2021

This is an amazing plugin. Incredibly useful.

I think the template substitution may cause grief in the helm chart when specifying multiple domains.

        domain:
          mydomain.com

works fine

        domain:
          mydomain.com myseconddomain.com

causes both to fail.

I believe it is because the configmap is generated like so

k8s_gateway "mydomain.com" {
      apex k8s-gateway.infra-system
      ttl 300
    }

and

k8s_gateway "mydomain.com myseconddomain.com" {
      apex k8s-gateway.infra-system
      ttl 300
    }

Workaround:
editing the configmap in the second case to not have quotes. E.g.

k8s_gateway mydomain.com myseconddomain.com {
      apex k8s-gateway.infra-system
      ttl 300
    }

works perfectly, but does mean it needs to be edited by hand after the helm deploy :).

Note: I'm deploying this using argocd, so unsure if that is maybe interfering as well. I would think not, but worth mentioning.

@networkop
Copy link
Collaborator

could be it just a matter of removing " in this line?

k8s_gateway "{{ required "Delegated domain ('domain') is mandatory " .Values.domain }}" {

@btrepp do you want to test to see if it works?

@btrepp
Copy link
Author

btrepp commented Sep 22, 2021

Bit of a noob on this but will do when I get a chance :)

@Oznup
Copy link

Oznup commented Nov 24, 2021

Hello, I have the same need, so this "simple" evolution could really be cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants