Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple domains #146

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Support multiple domains #146

merged 1 commit into from
Sep 17, 2022

Conversation

mhumeSF
Copy link
Contributor

@mhumeSF mhumeSF commented Sep 16, 2022

This issue was raised here #53

This small edit to configmap enables support for multiple domains.

# values.yaml
domain: foo.com bar.com

Result from `helm template ./k8s-gateway -f values.yaml

# Source: k8s-gateway/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: release-name-k8s-gateway
...
data:
  Corefile: |-
    .:1053 {
        k8s_gateway foo.com bar.com {
          apex release-name-k8s-gateway.cert-manager
          ttl 300
        }
        ...
    }

@networkop
Copy link
Collaborator

thanks @mhumeSF . Can you bump the helm chart version please? https://github.com/ori-edge/k8s_gateway#helm-charts

@mhumeSF
Copy link
Contributor Author

mhumeSF commented Sep 16, 2022

@networkop Sure thing – chart has been bumped with updated chart package and index.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants