Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 2 non deterministic tests
Steps to reproduce
To reproduce the problem, first build the module
core
:To identify the flaky test, execute the following nondex command:
The test failure occurred due to random attribute ordering produced by factory.classMap(Clazz, Clazz). When field(fromClassField, toClassField) is not called for all hierarchical attributes, any attributes left unassigned will appear in a random order.
The fix involves adding lexographical ordering for all unmapped attributes ( email and id in this case ).
The test failure occurred because the fields are not being mapped correctly by default.
The fix involves specifying explicit mappings for these fields.
For more information : https://github.com/TestingResearchIllinois/NonDex