Fix effectively ignored XML parameters for SZ operator #4404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem of ignored parameters from XML file for the SZ operator.
Problem:
The keys in
m_Parameter
are forced to lower case formatting duringOperator
construction. Hence, previous checks for corresponding parameters inCompressSZ.cpp
always failed, such that parameters set via an XML configuration were effectively ignored.Solution:
Without changing the enforced lower case formatting in
Operator
construction, avoiding possible side-effects, and not knowing the reasons for lower case formatting, the current PR suggests the most direct fix inOperatorSZ.cpp
.