Document store cloned from the original proposal on submission #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nes the document store of the original proposal
DJWalker42
deleted the
57-submitted-proposals-should-have-own-copy-of-uploaded-documents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a proposal to a cycle the API now copies the original proposal's document store to one uniquely identified by the new "submitted-proposal". In essence, this creates a snapshot of the documents in the store at the point when the proposal was submitted.
Notice that in doing this I have also moved the code that updates the clone's (or submitted-proposal's) supporting documents 'location' members into the implementation of 'ProposalDocumentStore.copyStore()' method.