Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth2client json pass jwks_uri when private_key_jwt #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

burahimu
Copy link

@burahimu burahimu commented Feb 7, 2025

Related Issue or Design Document

The jwks_uri parameter is never passed to the Hydra admin API. IMHO, If we want to use the private_key_jwt auth method we need to pass the jwks uri.

WDYT?

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Feel free to close the PR if it's not relevant

The jwks_uri parameter is never passed to the Hydra admin API. If we want to
use the private_key_jwt auth method we need to pass it.
@CLAassistant
Copy link

CLAassistant commented Feb 7, 2025

CLA assistant check
All committers have signed the CLA.

@burahimu burahimu changed the title feat(oauth2client json): pass jwks_uri when private_key_jwt feat: oauth2client json pass jwks_uri when private_key_jwt Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants