Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extra labels #639

Merged
merged 3 commits into from
Sep 25, 2023
Merged

feat: extra labels #639

merged 3 commits into from
Sep 25, 2023

Conversation

veikovx
Copy link
Contributor

@veikovx veikovx commented Sep 18, 2023

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Allow adding deployment level labels to Oathkeeper Maester, Copy of what Hydra Maester has

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Demonsthere Demonsthere changed the title Extra labels feat: extra labels Sep 18, 2023
Demonsthere
Demonsthere approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there :)
Please sign the CLA and we can merge this

@veikovx
Copy link
Contributor Author

veikovx commented Sep 25, 2023

Hello there :) Please sign the CLA and we can merge this

Done

@Demonsthere Demonsthere merged commit f79a0c8 into ory:master Sep 25, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demonsthere Demonsthere Demonsthere approved these changes

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veikovx @CLAassistant @Demonsthere