Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update values.yaml change varification to verification_code #692

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

spreeker
Copy link
Contributor

spend 8+ hours looking why my verifications emails where not styled when enabling the example settings commented out in valyes.yaml of kratos. fixed after a long time searching.

verficication now apparently is verification_code

solves confusion around #690

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

spend 8+ hours looking why my verifications emails where not styled when enabling these example settings. fixed
@CLAassistant
Copy link

CLAassistant commented Jun 26, 2024

CLA assistant check
All committers have signed the CLA.

@Demonsthere Demonsthere changed the title Update values.yaml change varification to verification_code fix: update values.yaml change varification to verification_code Jun 26, 2024
@Demonsthere Demonsthere merged commit 1a9dcfc into ory:master Jun 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants