Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keto Deployment strategy reference #698

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jagregory
Copy link
Contributor

The Keto chart references the Deployment strategy from the wrong location in the values.yaml file, this change updates the Deployment spec to use the correct location.

Related Issue or Design Document

Fixes #697

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jagregory jagregory changed the title fix: Keto Deployment strategy reference fix: keto Deployment strategy reference Aug 19, 2024
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@Demonsthere Demonsthere merged commit 7234d95 into ory:master Aug 20, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keto chart uses strategy from wrong location in values.yaml
2 participants