Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade hydra-maester image to 0.0.36 with deletionPolicy #716

Merged

Conversation

David-Wobrock
Copy link
Contributor

ory/hydra-maester#149 has been merged into hydra-maester.

Once a new version of hydra-matesre is released, we can bump the version in the charts and allow the new deletionPolicy setting for OAuth2 clients.

Related Issue or Design Document

ory/hydra-maester#149

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@David-Wobrock David-Wobrock force-pushed the feat/disable-oauth2-client-deletion branch from c579258 to d7925c0 Compare November 19, 2024 17:59
@David-Wobrock David-Wobrock marked this pull request as ready for review November 19, 2024 18:08
@Demonsthere
Copy link
Collaborator

looks like the CRD fails validation 😞

spec.validation.openAPIV3Schema.properties[spec].properties[deletionPolicy].type: Unsupported value: "int": supported values: "array", "boolean", "integer", "number", "object", "string"

we need to fix the CRD and re-relase it

Include new deletionPolicy setting for OAuth2 clients.
@David-Wobrock David-Wobrock force-pushed the feat/disable-oauth2-client-deletion branch from 1270f61 to c8420ee Compare November 26, 2024 13:24
@David-Wobrock
Copy link
Contributor Author

looks like the CRD fails validation 😞

spec.validation.openAPIV3Schema.properties[spec].properties[deletionPolicy].type: Unsupported value: "int": supported values: "array", "boolean", "integer", "number", "object", "string"

we need to fix the CRD and re-relase it

Hey @Demonsthere
I think that was only an issue in the file I pushed.

Looks better now, doesn't it?

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Demonsthere Demonsthere merged commit a6f4425 into ory:master Dec 4, 2024
11 checks passed
@David-Wobrock David-Wobrock deleted the feat/disable-oauth2-client-deletion branch December 4, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants