Some changes to work fine with Java 8 and Debezium 1.2.2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welinton-padua-picpay
commented
Nov 25, 2020
welinton-padua-picpay
commented
- Changing the debeziun lib version to 1.2.2.Final;
- Adding the slf4j log lib and remove sout;
- Making some corrections and improvements in general in the code to execute all the test scenarios;
- It is also necessary to rewrite a small part of the code to be compatible with the Java 8 version as described in the pom.xml
…ecute all the test scenarios. It is also necessary to rewrite a small part of the code to be compatible with the Java 8 version as described in the pom.xml
gimenez1987
reviewed
Nov 25, 2020
gimenez1987
reviewed
Nov 25, 2020
src/main/java/oryanmoshe/kafka/connect/util/TimestampConverter.java
Outdated
Show resolved
Hide resolved
gimenez1987
suggested changes
Nov 25, 2020
andersoncouto
approved these changes
Nov 25, 2020
Suggestions from CR Co-authored-by: Giuliano Gimenez <[email protected]>
gimenez1987
approved these changes
Nov 25, 2020
WashingtonFlorentino
approved these changes
Nov 25, 2020
|
Works on my machine when compiling using Java 8. Are there plans to merge this pr? |
|
I am able to build package in Java 8 and verified the changes works. However the released version 1.2.0 did not work in Java 8 and throws java.lang.NoSuchMethodError exception. This PR should be merged. |
welinton-padua-picpay
force-pushed
the
master
branch
from
9ab558f to
60ed946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.