Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openqa-load-templates: Slightly simplify #6004

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okurz
Copy link
Member

@okurz okurz commented Oct 11, 2024

No description provided.

@os-autoinst os-autoinst deleted a comment from mergify bot Oct 11, 2024
script/openqa-load-templates Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (fc5ba82) to head (6ffe1a8).
Report is 151 commits behind head on master.

Files with missing lines Patch % Lines
script/openqa-load-templates 63.63% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6004   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         396      396           
  Lines       39172    39170    -2     
=======================================
- Hits        38718    38717    -1     
+ Misses        454      453    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Martchus
Copy link
Contributor

I hope you have tested it manually.

script/openqa-load-templates Outdated Show resolved Hide resolved
@okurz
Copy link
Member Author

okurz commented Oct 16, 2024

I hope you have tested it manually.

nope. I trusted t/40-script_load_dump_templates.t

Copy link
Contributor

@b10n1k b10n1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a commit message. from the reviewers perspective I would like to know the context of the changes. for instance: in what logic or necessity there is change of the function. it also counts as a log for review in the future.

@okurz
Copy link
Member Author

okurz commented Oct 27, 2024

Please provide a commit message. from the reviewers perspective I would like to know the context of the changes. for instance: in what logic or necessity there is change of the function. it also counts as a log for review in the future.

There is no change of function, that should be implied in the message "slightly simplify". I could call it "Refactor slightly", is that better?

@asdil12
Copy link
Member

asdil12 commented Oct 31, 2024

I guess mostly the coverage is left here

@b10n1k
Copy link
Contributor

b10n1k commented Nov 1, 2024

Please provide a commit message. from the reviewers perspective I would like to know the context of the changes. for instance: in what logic or necessity there is change of the function. it also counts as a log for review in the future.

There is no change of function, that should be implied in the message "slightly simplify". I could call it "Refactor slightly", is that better?

The commit message could be something like Extracting this part because ... bla . it is simple pr, so I dont want to hold you back. if you dont like to add anything let me know and I will approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants