-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openqa-load-templates: Slightly simplify #6004
base: master
Are you sure you want to change the base?
Conversation
38fb410
to
f98ce82
Compare
f98ce82
to
23ecf8d
Compare
23ecf8d
to
2e74e81
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6004 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 396 396
Lines 39172 39170 -2
=======================================
- Hits 38718 38717 -1
+ Misses 454 453 -1 ☔ View full report in Codecov by Sentry. |
I hope you have tested it manually. |
2e74e81
to
6ffe1a8
Compare
nope. I trusted t/40-script_load_dump_templates.t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a commit message. from the reviewers perspective I would like to know the context of the changes. for instance: in what logic or necessity there is change of the function. it also counts as a log for review in the future.
There is no change of function, that should be implied in the message "slightly simplify". I could call it "Refactor slightly", is that better? |
I guess mostly the coverage is left here |
The commit message could be something like |
No description provided.