Fix order of commands #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
fix-ignore-heartbeat
branch
from
85be8d2 to
0197863
Compare
okurz
approved these changes
Aug 7, 2024
nicksinger
approved these changes
Aug 7, 2024
perlpunk
force-pushed
the
fix-ignore-heartbeat
branch
from
0197863 to
1d4288a
Compare
|
Added the issue to the commit message |
Martchus
approved these changes
Aug 7, 2024
See os-autoinst#49 The regex to include actually needs to be the last argument. And the regex in the test wasn't really matching because the escaping of \( is probably wrong, so I reduced that, as in the test we only need to match for the unique thing in our example log. Issue: https://progress.opensuse.org/issues/165033
perlpunk
force-pushed
the
fix-ignore-heartbeat
branch
from
1d4288a to
f367815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #49
The regex to include actually needs to be the last argument.
And the regex in the test wasn't really matching because the escaping of
\(is probably wrong, so I reduced that, as in the test we only need to matchfor the unique thing in our example log. That's why the test was passing.
Issue: https://progress.opensuse.org/issues/165033