Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Cloud: Reuse resources in Google and Azure #18202

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

pdostal
Copy link
Member

@pdostal pdostal commented Nov 27, 2023

BuildPDOSTAL of sle-15-SP5-EC2-Updates.aarch64 publiccloud_consoletests@64bit 23 16 minutes ago
BuildPDOSTAL of sle-15-SP5-EC2-BYOS-Updates.x86_64 publiccloud_consoletests@64bit 23 23 minutes ago
BuildPDOSTAL of sle-15-SP5-GCE-BYOS-Updates.aarch64 publiccloud_containers@64bit 25 38 minutes ago
BuildPDOSTAL of sle-15-SP5-Azure-BYOS-Updates.aarch64 publiccloud_img_proof@64bit 24 about an hour ago
BuildPDOSTAL of sle-15-SP5-Azure-Basic-Updates.x86_64 publiccloud_cloud_netconfig@64bit 7 about an hour ago
BuildPDOSTAL of sle-15-SP5-GCE-Updates.x86_64 publiccloud_img_proof@64bit 28 about an hour ago

Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure these resources are not cleaned up by pcw?

@pdostal pdostal marked this pull request as draft November 27, 2023 12:21
@pdostal
Copy link
Member Author

pdostal commented Nov 27, 2023

Are you sure these resources are not cleaned up by pcw?

You may so far check gitlab.suse.de/qac/terraform#373624. Maybe @asmorodskyi would also like to join here.

I'm right now working on Terraform merge request for Amazon.

@asmorodskyi
Copy link
Member

Are you sure these resources are not cleaned up by pcw?

didn't get your question . whole point here is to NOT do a cleanup but also NOT to create anything new by tests ( meaning network infra ofc. we still want to create VMs )

@ricardobranco777
Copy link
Contributor

Are you sure these resources are not cleaned up by pcw?

didn't get your question . whole point here is to NOT do a cleanup but also NOT to create anything new by tests ( meaning network infra ofc. we still want to create VMs )

We're reusing resources and we must make sure those are always available - not cleanup by pcw.

@asmorodskyi
Copy link
Member

Are you sure these resources are not cleaned up by pcw?

didn't get your question . whole point here is to NOT do a cleanup but also NOT to create anything new by tests ( meaning network infra ofc. we still want to create VMs )

We're reusing resources and we must make sure those are always available - not cleanup by pcw.

fully agree ! And this will be done by appropriate tagging of created resources . Keep in mind this PR is just a piece of the puzzle . Pavel preparing another PRs ( to different repo ) which will hold terraform profile to create this network entities ( and pipelines which will make sure that resources will be re-created even if PCW or someone else will delete them )

@pdostal
Copy link
Member Author

pdostal commented Dec 1, 2023

Blocked by SUSE/pcw#328

@pdostal pdostal self-assigned this Dec 7, 2023
@pdostal pdostal marked this pull request as ready for review December 7, 2023 10:19
@asmorodskyi asmorodskyi merged commit b51c0d7 into os-autoinst:master Dec 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants