Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot ID capture in snapper_zypp test #21075

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

cedvid
Copy link
Contributor

@cedvid cedvid commented Jan 28, 2025

Fixed the capture of snapshot ID. The test was failing in svirt-xen-hvm environment because the output of snapper ls included unwanted BTRFS info.

@cedvid cedvid force-pushed the snapper-zypp2 branch 9 times, most recently from f96b34a to da012fb Compare February 3, 2025 14:05
@cedvid cedvid changed the title Fix snapper_zypp test Fix snapshot ID capture in snapper_zypp test Feb 3, 2025
@cedvid cedvid marked this pull request as ready for review February 3, 2025 15:13
@cedvid cedvid added Ready Ready for review qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them labels Feb 3, 2025
@cedvid cedvid requested a review from Vogtinator February 3, 2025 15:14
Copy link
Member

@Vogtinator Vogtinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually doubt that this helps.

The unwanted output is not coming from snapper, it's coming from the kernel, triggered by snapper's btrfs qgroup refresh.

To fix this properly, either the kernel needs to be told to stay quiet, or a different method is used for getting script output.

If possible, this could also invoke snapper list with --disable-used-space to skip the qgroup refresh.

@cedvid
Copy link
Contributor Author

cedvid commented Feb 4, 2025

@Vogtinator I’m not sure if you’ve had a chance to see the verification run, but the test is passing on svirt-xen-hvm with the change I made. If you think I should still look into the suggestions you mentioned, I’m happy to do so

@Vogtinator
Copy link
Member

@Vogtinator I’m not sure if you’ve had a chance to see the verification run, but the test is passing on svirt-xen-hvm with the change I made. If you think I should still look into the suggestions you mentioned, I’m happy to do so

The root cause of broken serial_output on svirt-xen-kvm remains. I don't know whether using --columns number disables qgroup refresh or if this run was just lucky to not emit the kernel message.

On 12 SP5 it will likely still fail.

@cedvid cedvid force-pushed the snapper-zypp2 branch 4 times, most recently from 8698700 to 94494bc Compare February 5, 2025 11:02
@cedvid cedvid removed the Ready Ready for review label Feb 5, 2025
@cedvid cedvid requested a review from Vogtinator February 5, 2025 13:39
Copy link
Member

@Vogtinator Vogtinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work. Arguably this should be done for svirt-hvm-xen specifically though and not just here in this place.

@cedvid cedvid merged commit 322ad2d into os-autoinst:master Feb 6, 2025
10 checks passed
@cedvid cedvid deleted the snapper-zypp2 branch February 6, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants