-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snapshot ID capture in snapper_zypp test #21075
Conversation
f96b34a
to
da012fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually doubt that this helps.
The unwanted output is not coming from snapper, it's coming from the kernel, triggered by snapper's btrfs qgroup refresh.
To fix this properly, either the kernel needs to be told to stay quiet, or a different method is used for getting script output.
If possible, this could also invoke snapper list
with --disable-used-space
to skip the qgroup refresh.
@Vogtinator I’m not sure if you’ve had a chance to see the verification run, but the test is passing on svirt-xen-hvm with the change I made. If you think I should still look into the suggestions you mentioned, I’m happy to do so |
The root cause of broken On 12 SP5 it will likely still fail. |
8698700
to
94494bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work. Arguably this should be done for svirt-hvm-xen specifically though and not just here in this place.
Fixed the capture of snapshot ID. The test was failing in svirt-xen-hvm environment because the output of
snapper ls
included unwanted BTRFS info.