Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change is_byos to case insensitive #21098

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Change is_byos to case insensitive #21098

wants to merge 1 commit into from

Conversation

mpagot
Copy link
Contributor

@mpagot mpagot commented Jan 31, 2025 •
edited
Loading

is_byos is a PC utils lib checking content of FLAVOR against a regexp. Change this test to be case in-sensitive.

Related ticket: https://jira.suse.com/browse/TEAM-9933

Verification run:

@mpagot
Change is_byos to case insensitive
a2b3572 
is_byos is a PC utils lib checking content of FLAVOR agains a regexp.
Change this test to be case in-sensitive.
@github-actions GitHub Actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/publiccloud/**.pm:

  • Provide VRs for both QE-C as well as QE-SAP (check Confluence for more info)

This is an automatically generated QA checklist based on modified files.

BillAnastasiadis
BillAnastasiadis approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillAnastasiadis BillAnastasiadis BillAnastasiadis approved these changes

@rbmarliere rbmarliere rbmarliere approved these changes

@pdostal pdostal Awaiting requested review from pdostal pdostal will be requested when the pull request is marked ready for review pdostal is a code owner

@grisu48 grisu48 Awaiting requested review from grisu48 grisu48 will be requested when the pull request is marked ready for review grisu48 is a code owner

@asmorodskyi asmorodskyi Awaiting requested review from asmorodskyi asmorodskyi will be requested when the pull request is marked ready for review asmorodskyi is a code owner

@ricardobranco777 ricardobranco777 Awaiting requested review from ricardobranco777 ricardobranco777 will be requested when the pull request is marked ready for review ricardobranco777 is a code owner

@m-dati m-dati Awaiting requested review from m-dati m-dati will be requested when the pull request is marked ready for review m-dati is a code owner

@alvarocarvajald alvarocarvajald Awaiting requested review from alvarocarvajald alvarocarvajald will be requested when the pull request is marked ready for review alvarocarvajald is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpagot @rbmarliere @BillAnastasiadis