Chore: Pull DevOps tooling from upstream repository #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit created by automation/scripting Signed-off-by: Matthew Watkins <[email protected]>
|
Any chance you can review this? Should address some inconsistencies in the linting setup, such as missing isort and test naming. |
emileten
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Although i am not familiar with the details of the configuration you're importing, I am in favor of using something centralized.
A reminder that now my main struggle has been this #56 and this doesn't solve it yet -- we need another PR.
Like you already said, we also should separate tests and formatting in separate github actions or jobs. Right now it's all happening in pdm run.
ModeSevenIndustrialSolutions
merged commit b6101f4
into
os-climate:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated by a GitHub workflow: bootstrap.yaml