Revoking work in progress for instance nets at elaboration time (EDA-2699) #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
- Coverage 13.48% 13.47% -0.01%
==========================================
Files 472 472
Lines 60371 60365 -6
Branches 23758 23755 -3
==========================================
- Hits 8139 8133 -6
Misses 51287 51287
Partials 945 945 ☔ View full report in Codecov by Sentry. |
chungshien-chai
approved these changes
Apr 14, 2024
| ports_map_[pr.first]->set_enclosing_instance(this); | ||
| std::cout << "Port Net :: " << pr.first << std::endl; | ||
| } | ||
| // for (const auto &pr : instaciated_block_ptr_->nets()) { |
There was a problem hiding this comment.
Why are we commenting the code out ? There's no details in the description to understand this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssian.net/browse/EDA-2699