Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO bitstream generation #1548

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Conversation

chungshien-chai
Copy link
Collaborator

@chungshien-chai chungshien-chai commented Apr 24, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

Changes include:
a. Provide API to validate parameter(s) before using it. (Use case: for example PLL need to validate the multiply and division params)
b. Prepare to support clock routing to gearbox. In the progress understanding RTL what to set in bits to support.

Testing:
a. ported code (together with os-fpga/yosys_verific_rs#626) to latest NS Raptor manually
b. run batch, batch_gen2 and batch_gen3 test.

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@chungshien-chai chungshien-chai changed the title Foedag primitive advance connection IO bitstream generation Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 68.06723% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 13.85%. Comparing base (338a3af) to head (0b4cac0).

Files Patch % Lines
src/Configuration/ModelConfig/ModelConfig_IO.cpp 68.06% 9 Missing and 29 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
+ Coverage   13.74%   13.85%   +0.10%     
==========================================
  Files         473      473              
  Lines       60651    60767     +116     
  Branches    24029    24107      +78     
==========================================
+ Hits         8339     8417      +78     
- Misses      51343    51349       +6     
- Partials      969     1001      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai
Copy link
Collaborator Author

@NadeemYaseen , all macos failed because of python version - https://github.com/os-fpga/FOEDAG/actions/runs/8823274431/job/24223371267?pr=1548. But my changes does not change anything on workflows.

@alaindargelas
Copy link
Contributor

alaindargelas commented Apr 24, 2024

@NadeemYaseen @chungshien-chai , We need to resolve the MacOS failures before merge

@ravikiranchollangi
Copy link
Contributor

@NadeemYaseen , all macos failed because of python version - https://github.com/os-fpga/FOEDAG/actions/runs/8823274431/job/24223371267?pr=1548. But my changes does not change anything on workflows.

It's related to Python version support in latest macOS on CI. Unless @nadeemyaseen-rs has a solution to use the version we need, we should pin the macOS to previous one for time being.

@NadeemYaseen
Copy link
Contributor

This #1549 will hopefully fix the MacOS issue

@ravikiranchollangi ravikiranchollangi merged commit e9d1728 into main Apr 25, 2024
36 checks passed
@ravikiranchollangi ravikiranchollangi deleted the foedag-primitive-advance-connection branch April 25, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants