-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack to vite #814
base: master
Are you sure you want to change the base?
webpack to vite #814
Conversation
12cd2de
to
ebcd151
Compare
runtime error
edit:
|
runtime error
that png is part of
https://github.com/os-js/osjs-panels/blob/master/src/logo-blue-32x32.png seems like webpack UMD is not compatible with vite ... /* harmony import */ var _logo_blue_32x32_png__WEBPACK_IMPORTED_MODULE_3__ = __webpack_require__(/*! ../logo-blue-32x32.png */ "./src/logo-blue-32x32.png");
/* harmony import */ var _logo_blue_32x32_png__WEBPACK_IMPORTED_MODULE_3___default = /*#__PURE__*/__webpack_require__.n(_logo_blue_32x32_png__WEBPACK_IMPORTED_MODULE_3__); i hope this is solved when we build all packages with vite vite will inline that png image like const defaultIcon = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAA..."; |
Hey @milahu . I've been out sick, so haven't had a chance to look at your stuff. Looks promising though. I didn't go the Vite route because upgrading Webpack will basically just "make it work" as it should again :) I'll try to have a look this weekend. |
@andersevenrud the vite thing would be maybe more great on the long run out of uptranspiling view. While i agree it is not needed the only problem is the CSS at present and i have a complet rewrite ongoing which does not use CSS imports i assign the css directly to the elements. i am not the biggest fan of hyperapp it self but it is better then nothing and is better then react. And it is highly compatible so i keep it. but i will add all new components via Object.assign(el,...props) because why a framework when this wonderful buildIn exists. |
even getting this to build clean again would be great for the current state. i got it partial build via --legacy tls flags but there are icons missing and i fixed it in the rewrite. |
fix #785
fix os-js/osjs-dev-meta#25