-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure root_t label for /store #197
Conversation
The other thing I did briefly mess around with here is that in theory the existing |
Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
AIUI, this will not be necessary when we switch to using bootc install
(osbuild/images#462).
Probably/hopefully yes, but OTOH I think this is generally right as a generic baseline anyways. |
LGTM |
OK this one just needs a quick re-stamp for approval, I just did a minor tweak to avoid a textual/logical conflict with #238 |
The way osbuild works is to synthesize a filesystem tree in the store, then copy it to the disk. This ensures the label for the store is `root_t` which ends up being the labeling for the "infrastructure" bits in the `/ostree` repository in the target root. This in turn is blocking a lot of things. Closes: osbuild#149
Oops, stray whitespace change still led to a conflict. Fixed. |
The way osbuild works is to synthesize a filesystem tree in the store, then copy it to the disk. This ensures the label for the store is
root_t
which ends up being the labeling for the "infrastructure" bits in the/ostree
repository in the target root.This in turn is blocking a lot of things.
Closes: #149