Skip to content

Commit

Permalink
address more comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasBreuer committed Jan 8, 2025
1 parent 2cbfbc5 commit 1e74371
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
- simpcomp
- singular
- zeromqinterface
- Add `GAP.versioninfo()`
- Optimize conversion of GAP strings to Julia strings, symbols or `Vector{UInt8}`

## Version 0.12.3 (released 2025-01-01)
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ nauty_jll = "55c6dc9b-343a-50ca-8ff2-b71adb3733d5"
AbstractAlgebra = "0.41.11, 0.42.1, 0.43, 0.44"
Artifacts = "1.6"
BinaryWrappers = "0.1.3"
Compat = "4.4.0"
Compat = "4.11"
Downloads = "1.4.3"
GAP_jll = "~400.1400.000"
GAP_lib_jll = "~400.1400.000"
Expand Down
4 changes: 2 additions & 2 deletions src/GAP.jl
Original file line number Diff line number Diff line change
Expand Up @@ -321,14 +321,14 @@ function randseed!(seed::Union{Integer,Nothing}=nothing)
end

"""
versioninfo(io::IO = stdout; jll::Bool = false)
versioninfo(io::IO = stdout; jll::Bool = false, full::Bool = false)
Print the version numbers of GAP.jl and GAP,
and version numbers and installation paths of all currently loaded GAP packages.
Note that these paths can be nonstandard because Julia's package manager
does not control which available version of a GAP package gets loaded.
If `jll` is `true` then also the underlying binary packages (jll),
If `jll` or `full` is `true` then also the underlying binary packages (jll),
if available, of all installed (not necessarily loaded) packages
are included in the output.
"""
Expand Down
2 changes: 1 addition & 1 deletion test/basics.jl
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ end

@testset "versioninfo" begin
io = IOBuffer()
GAP.versioninfo(io, jll = true)
GAP.versioninfo(io; full = true)
str = String(take!(io))
@test startswith(str, "GAP.jl version")
end

0 comments on commit 1e74371

Please sign in to comment.