Ensure all gap_to_julia method handle 'recursive' kwarg #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of relying on a dodgy catch-all method which handles that kwarg
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
- Coverage 75.73% 75.73% -0.01%
==========================================
Files 55 55
Lines 4641 4640 -1
==========================================
- Hits 3515 3514 -1
Misses 1126 1126
|
ThomasBreuer
approved these changes
Jan 7, 2025
lgoettgens
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of relying on a dodgy catch-all method which handles that kwarg
The required changes for Oscar.jl are in oscar-system/Oscar.jl#4419
Also update CHANGES.md to point out breaking changes