Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Julia 1.12 worldage issue #1134

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

fingolfin
Copy link
Member

Fix part of #1132? Namely those in pkg/JuliaInterface/tst/calls.tst related to function f0() etc..

Based on https://github.com/JuliaLang/julia/pull/57133/files#diff-42a3fc6ebd78315e40602ab4108f5cd380ada14ff81987b696d7b4ee9372a4deR2591-R2600 which adjust the C kernel function jl_get_function to avoid the same warning:

STATIC_INLINE jl_function_t *jl_get_function(jl_module_t *m, const char *name)
{
    jl_task_t *ct = jl_get_current_task();
    size_t last_world = ct->world_age;
    ct->world_age = jl_get_world_counter();
    jl_value_t *r = jl_get_global(m, jl_symbol(name));
    ct->world_age = last_world;
    return (jl_function_t*)r;
}

The warnings involving docmeta are still there, though. I have not yet analyzed where they are triggered exactly (obvious guess is test/doctest.jl); perhaps some invokelatest placed there will resolve them?

@fingolfin fingolfin marked this pull request as draft January 28, 2025 01:59
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (707f1f8) to head (aea8b0e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/JuliaInterface/src/JuliaInterface.c 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   81.75%   82.83%   +1.07%     
==========================================
  Files          50       50              
  Lines        3820     3827       +7     
==========================================
+ Hits         3123     3170      +47     
+ Misses        697      657      -40     
Files with missing lines Coverage Δ
pkg/JuliaInterface/src/JuliaInterface.c 78.90% <88.88%> (+1.22%) ⬆️

... and 2 files with indirect coverage changes

@lgoettgens
Copy link
Member

The warnings involving docmeta are still there, though. I have not yet analyzed where they are triggered exactly (obvious guess is test/doctest.jl); perhaps some invokelatest placed there will resolve them?

These are not due do anything in GAP,jl, but are reproducible with just an empty package and Documenter.jl, see JuliaDocs/Documenter.jl#2621.

@fingolfin fingolfin marked this pull request as ready for review January 28, 2025 13:12
@fingolfin fingolfin merged commit b1669ff into oscar-system:master Jan 28, 2025
166 checks passed
@fingolfin fingolfin deleted the mh/worldage branch January 28, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants