Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rationalized 2F4 #97

Merged
merged 1 commit into from
Aug 13, 2024
Merged

rationalized 2F4 #97

merged 1 commit into from
Aug 13, 2024

Conversation

SoongNoonien
Copy link
Member

Hm, maybe I have to do this again... Starting from character 29 the norm can't be computed or looks just wrong. Also 2F4.2 is still not converted.

@SoongNoonien SoongNoonien marked this pull request as draft July 23, 2024 22:29
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (129dab2) to head (5f3657a).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   70.37%   71.14%   +0.76%     
==========================================
  Files          10       10              
  Lines         908      901       -7     
==========================================
+ Hits          639      641       +2     
+ Misses        269      260       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoongNoonien
Copy link
Member Author

SoongNoonien commented Aug 13, 2024

I've now also converted 2F4.2. After conversion the diff of both files is still essentially the same. They still differ in the exact same places, so I'm fairly certain that I didn't make any mistake. Regarding the weird norms I've mentioned earlier: After some testing with the old tables I've noticed that they where there before, so they are a separate issue. I'll open a bug with additional information later.

@SoongNoonien SoongNoonien marked this pull request as ready for review August 13, 2024 16:43
@SoongNoonien SoongNoonien merged commit 6468481 into oscar-system:master Aug 13, 2024
6 of 7 checks passed
@SoongNoonien SoongNoonien deleted the 2F4 branch August 14, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant