Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TagBot.yml #86

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update TagBot.yml #86

merged 1 commit into from
Jul 23, 2024

Conversation

lgoettgens
Copy link
Member

This is how it is suggested to be used in https://github.com/JuliaRegistries/TagBot?tab=readme-ov-file#setup

I imagine that this is a reason that TagBot doesn't do proper releases on this repository, but only tags versions.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (cd48ab9) to head (1bcb1c7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   70.37%   70.37%           
=======================================
  Files          10       10           
  Lines         908      908           
=======================================
  Hits          639      639           
  Misses        269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SoongNoonien SoongNoonien requested a review from fingolfin July 22, 2024 15:39
@fingolfin
Copy link
Member

TagBot doesn't do proper releases on this repository, but only tags versions

Not sure what you mean by that? They do have releases, but the way GitHub Action work is via git refs, including tags that stand in for "1.x" (i.e. v1) and so on.

Anyway this seems to be irrelevant for this PR

@fingolfin fingolfin merged commit 6b6cdd8 into oscar-system:master Jul 23, 2024
7 of 8 checks passed
@fingolfin
Copy link
Member

Oh wait I totally misunderstood you: what you meant is that TagBot failed to create releases on this repository. Yeah, true. But I think that was the permissions in the project settings, which I just adjusted.

@fingolfin
Copy link
Member

I.e. the picture just below the section in the TagBot README that you linked to

@fingolfin
Copy link
Member

(My mistake was that I read the two paragraphs in your description subsequently; so after looking at the TagBot README link pointing at the TagBot repository, I read "this repository" as "the TagBot repository". Which is "obviously nonsense", but as so often with misunderstandings, the "obvious" part only is "obvious" after you understood what you misunderstood sigh)

@lgoettgens lgoettgens deleted the patch-1 branch July 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants