This fixes SciML#292. It turns out we were asking for interpolated de…

…rivatives for essentially no reason (and doing so caused problems whenever you hit callbacks). As a nice side-benefit, this removes the 200 warnings
oscardssmith · Jun 21, 2023 · 2603b14 · 2603b14
1 parent 090c2d4
commit 2603b14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/common_interface/integrator_utils.jl b/src/common_interface/integrator_utils.jl
@@ -69,7 +69,7 @@ function DiffEqBase.savevalues!(integrator::AbstractSundialsIntegrator,
                     integrator.opts.save_idxs)
         push!(integrator.sol.t, integrator.t)
         if integrator.opts.dense
-            tmp = integrator(integrator.t, Val{1})
+            tmp = DiffEqBase.get_du(integrator)
             save_value!(integrator.sol.interp.du, tmp, uType,
                         integrator.opts.save_idxs)
         end
@@ -151,11 +151,11 @@ function DiffEqBase.terminate!(integrator::AbstractSundialsIntegrator,
     integrator.opts.tstops.valtree = typeof(integrator.opts.tstops.valtree)()
 end
 
-@inline function DiffEqBase.get_du(integrator::CVODEIntegrator)
+@inline function DiffEqBase.get_du(integrator::AbstractSundialsIntegrator)
     integrator(integrator.t, Val{1})
 end
 
-@inline function DiffEqBase.get_du!(out, integrator::CVODEIntegrator)
+@inline function DiffEqBase.get_du!(out, integrator::AbstractSundialsIntegrator)
     integrator(out, integrator.t, Val{1})
 end
 

diff --git a/src/common_interface/solve.jl b/src/common_interface/solve.jl
@@ -1432,7 +1432,6 @@ function DiffEqBase.solve!(integrator::AbstractSundialsIntegrator; early_free =
                     integrator.opts.save_idxs)
         push!(integrator.sol.t, integrator.t)
         if integrator.opts.dense
-            integrator(integrator.u, integrator.t, Val{1})
             save_value!(integrator.sol.interp.du, integrator.u, uType,
                         integrator.opts.save_idxs)
         end