Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5.8 kernel compilation #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix 5.8 kernel compilation #1

wants to merge 2 commits into from

Conversation

donporter
Copy link
Member

@donporter donporter commented Aug 24, 2020

Local mirror of SGX driver, tracking PR to fix build on 5.8 kernel and newer.

intel#120


This change is Reviewable

Copy link

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @donporter)

a discussion (no related file):
Could you link intel#120 in the PR description? (for bookkeeping)



sgx_encl.c, line 335 at r1 (raw file):

		mmap_read_unlock(encl->mm);
#else
 		up_read(&encl->mm->mmap_sem);

please drop this accidental space


sgx_page_cache.c, line 1 at r1 (raw file):

 /*

looks like accidental change?

Copy link
Member Author

@donporter donporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mkow)

a discussion (no related file):

Previously, mkow (Michał Kowalczyk) wrote…

Could you link intel#120 in the PR description? (for bookkeeping)

Done.



sgx_encl.c, line 335 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

please drop this accidental space

Done.


sgx_page_cache.c, line 1 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

looks like accidental change?

Done.

Copy link

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @donporter)

a discussion (no related file):
Seems intel#120 was just merged, so we don't need this subrepo, at least for now :)



sgx_encl.c, line 335 at r1 (raw file):

Previously, donporter (Don Porter) wrote…

Done.

Not done?


sgx_page_cache.c, line 1 at r1 (raw file):

Previously, donporter (Don Porter) wrote…

Done.

Not done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants