-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 5.8 kernel compilation #1
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Don Porter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @donporter)
a discussion (no related file):
Could you link intel#120 in the PR description? (for bookkeeping)
sgx_encl.c, line 335 at r1 (raw file):
mmap_read_unlock(encl->mm); #else up_read(&encl->mm->mmap_sem);
please drop this accidental space
sgx_page_cache.c, line 1 at r1 (raw file):
/*
looks like accidental change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mkow)
a discussion (no related file):
Previously, mkow (Michał Kowalczyk) wrote…
Could you link intel#120 in the PR description? (for bookkeeping)
Done.
sgx_encl.c, line 335 at r1 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
please drop this accidental space
Done.
sgx_page_cache.c, line 1 at r1 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
looks like accidental change?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @donporter)
a discussion (no related file):
Seems intel#120 was just merged, so we don't need this subrepo, at least for now :)
sgx_encl.c, line 335 at r1 (raw file):
Previously, donporter (Don Porter) wrote…
Done.
Not done?
sgx_page_cache.c, line 1 at r1 (raw file):
Previously, donporter (Don Porter) wrote…
Done.
Not done?
Local mirror of SGX driver, tracking PR to fix build on 5.8 kernel and newer.
intel#120
This change is