Improve account using meta feature
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafeychine
force-pushed
the
lafeychine/account_meta
branch
from
7feaed7 to
3f9fd27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that the modification made #100 had two major flaws.
On one hand, there was too much logic in the
playbook.accounts__usersin theosm2pgsqlplaybook drastically changes the semantics (because no longer overwrite the variable).osm2pgsql__user).On the other hand, this was impossible to ensure the uniqueness of the user, which is a problem especially with roles like
overpass-apiwhere the name of the service user is used a lot.I use meta, which is dedicated to this type of task.
Edit: Force-pushed to remove the
ansible-lintissue about capitalise word