Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extract user account from common #97

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

lafeychine
Copy link
Contributor

As requested by @jocelynj, extracting account creation from common to create new accounts simpler.

The following changes had been made:

  • Extract users creation into a new role users;
  • Add the new playbook accounts.yml to create a user (the playbook common.yml behaves in the same way as before);
  • Create an "all" group_vars with a dictionary of every user;
  • Update syntax to Ansible 2 (Remove warnings).

The following regressions are:

  • Breaking change: The shell /bin/bash is not set up during the first creation.

    The removed complex logic to check if an account exists is necessary for this fact, as the shell is not set up any more.
    In fact, the ansible.builtin.user Ansible module overrides any value changed by the user, and provides no way to leave it untouched.
    Since every machine is running on Debian, the shell is in any case /bin/bash by default.

  • Duplicating .gitconfig and .vimrc, files.

    The roles/users/files location is the expected location for these files.
    However, there are still tasks (shared/project-account.yml and roles/common/tasks/ssh-tunnel.yml) that seem redundant with this new users role, but I need some guidance before making any changes.

As this is my first PR on the project, feel free to tell me if I need to change anything.

@lafeychine
Copy link
Contributor Author

The force-pushed branch is an unsquash from the work done.

@jocelynj jocelynj merged commit 76c5e63 into osm-fr:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants