SCRIPTS: Add script to merge geojson files and format them in a MapRoulette tag fix friendly way #376
Conversation
…ulette tag fix friendly way Signed-off-by: Taylor Smock <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
| return [g for g in files if re.search(r".*\.geojson(|\.gz)$", g)] | ||
|
|
||
|
|
||
| def fix_suggestions_to_cooperativeWork( |
There was a problem hiding this comment.
This is great, thanks for adding it.
We're working on bringing in a pyatlas-checks library to house some MapRoulette related code integrated with the maproulette-python-client.
Once we have that checked in, we can repurpose this code within that cli.
Also.. check out this ticket: osmlab/maproulette-python-client#63. If you have time, it would be awesome if you could additionally add a Cooperative Challenge model for the python client.
Mostly because it was easier to work with organized checks to create MapRoulette tasks (when I first made the script, all I wanted to do was merge a specific check's files together -- I often run multiple checks instead of just the one I'm working on, to make certain I didn't accidentally break something). It eventually grew into what it is now, step by step. I added the I didn't know we had a python client repository (but I didn't look either -- I wrongly assumed that everything related to atlas-checks would be in this repo). |
| fh.write(ASCII_RECORD_SEPARATOR) | ||
|
|
||
| with open(file_name, "a") as fh: | ||
| string = geojson.dumps(fc) |
There was a problem hiding this comment.
I am guessing this is just calling json.dumps, in which case we probably want to set ensure_ascii=False to maintain unicode characters.
| parser.add_argument("--line-by-line", action="store_true") | ||
| args = parser.parse_args() | ||
| for f in args.files: | ||
| logging.info(f) |
There was a problem hiding this comment.
Nit: more context in this log would be good
| description="Create a line-by-line geojson file" | ||
| ) | ||
| parser.add_argument("files", nargs="+") | ||
| parser.add_argument("-c", "--checks", nargs="?") |
There was a problem hiding this comment.
Based on the use of this argument it appears to be expecting a single check name. So I think it would make more sense to have the flag be --check.
Description:
This is a script I wrote awhile back to convert multiple geojson files into a single geojson file. To help with uploading to MapRoulette, there is also a command line flag that converts the geojson files into RFC7464 compliant line-by-line geojson. As a followup on #361 , I modified the script to also convert basic
fix_suggestionsinto MapRoulette cooperative challenges when outputting RFC7464 compliant geojson in order to help me validate the fix suggestion changes I made to the InvalidTagsCheck class.There are a couple of
TODOcomments scattered throughout the file, mostly to do with investigating some edge cases (will Polygons always be a way, or may they occasionally be a relation? -- looking at identifiers would probably work for this as well).This is partially related to #365 .
Potential Impact:
N/A
Unit Test Approach:
N/A
Test Results:
N/A