-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate building tags #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @isabelleh!
Oh no, |
@MikeGost oh no >.< alright, I think it's probably best to just comment out that test then? It's still somewhat useful as a performance check, but clearly not reliable enough to be included by default |
I too have been bitten by my own questionable multithreaded tests :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @isabelleh!
@isabelleh - Do you mind adding the |
Relevant issue: #250 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to add Ignore tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description:
This is a quick fix to my previous PR which introduced a bug by duplicating a number of tags in the
VALID_BUILDINGS
enum set. #244Potential Impact:
This will effect code calling the
isBuilding
method.Unit Test Approach:
No additional unit testing.
Test Results:
Passes integration tests.
In doubt: Contributing Guidelines