Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local_staking_proxy mock from native_staking #150

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

uint
Copy link
Contributor

@uint uint commented Oct 18, 2023

Part of #95

@uint uint requested a review from maurolacy October 18, 2023 10:07
@uint uint force-pushed the 95-remove-mocks-in-native-staking branch from e3ffb81 to 3e11b64 Compare October 18, 2023 10:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b11d54c) 86.17% compared to head (bc2f93d) 88.98%.
Report is 66 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   86.17%   88.98%   +2.80%     
==========================================
  Files          70       69       -1     
  Lines       10447    13041    +2594     
  Branches    10447    13041    +2594     
==========================================
+ Hits         9003    11604    +2601     
- Misses       1004     1026      +22     
+ Partials      440      411      -29     
Files Coverage Δ
contracts/provider/native-staking/src/multitest.rs 99.66% <100.00%> (+0.05%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will do the suggested changes and merge.

contracts/provider/native-staking/src/multitest.rs Outdated Show resolved Hide resolved
contracts/provider/native-staking/src/multitest.rs Outdated Show resolved Hide resolved
contracts/provider/native-staking/src/multitest.rs Outdated Show resolved Hide resolved
@maurolacy maurolacy merged commit c0441cc into main Oct 19, 2023
4 checks passed
@maurolacy maurolacy deleted the 95-remove-mocks-in-native-staking branch October 19, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants