Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdns native dart impl to configure #40

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Add mdns native dart impl to configure #40

merged 2 commits into from
Mar 17, 2024

Conversation

git-elliot
Copy link
Contributor

  1. Type casting for hostIds passed as string.
  2. Added missing mdns scanner impl initialization
  3. Separate logger for flutter package.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 28.40%. Comparing base (c14877c) to head (a6da0e9).

Files Patch % Lines
lib/src/configure_flutter.dart 75.00% 1 Missing ⚠️
...vices_impls/host_scanner_service_flutter_impl.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #40      +/-   ##
==========================================
+ Coverage   26.74%   28.40%   +1.66%     
==========================================
  Files           4        5       +1     
  Lines          86       88       +2     
==========================================
+ Hits           23       25       +2     
  Misses         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-elliot git-elliot merged commit da2fbda into dev Mar 17, 2024
5 checks passed
@git-elliot git-elliot deleted the mdns-init branch March 17, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant