Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if updating wrong settings after setup #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abrandemuehl
Copy link
Contributor

Some settings can't be updated after calling setup, now users will be warned if they try to do so after setup

Some settings can't be updated after calling `setup`, now users will be
warned if they try to do so after `setup`
@CLAassistant
Copy link

CLAassistant commented Nov 18, 2019

CLA assistant check
All committers have signed the CLA.

@imciner2
Copy link
Member

Thanks for doing this and sorry it hasn't been looked at until now. There is actually already a check in the Matlab class wrapper here https://github.com/oxfordcontrol/osqp-matlab/blob/master/osqp.m#L569 that is supposed to stop the setting of these settings after the initial setup. It would be better if the other settings that don't work after initialization are added to that check instead of in the mex file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants