Rename params to parameters #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial suggestion was to use `params` for the parameter dict and `parameters` for the parameter panel widget. I found however the usage of `parameters` for the panel confusing so I would not go with this suggestion. The abbreviation is therefore not needed anymore.
agoscinski
force-pushed
the
rename-params-to-parameters
branch
from
45744ea to
c928c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial suggestion was to use
paramsfor the parameter dict andparametersfor the parameter panel widget. I found however the usage ofparametersfor the panel confusing so I would not go with this suggestion. The abbreviation is therefore not needed anymore.📚 Documentation preview 📚: https://scicode-widgets--104.org.readthedocs.build/en/104/