Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display by default not the set_all_references_button in the CheckRegistry #44

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Jun 27, 2024

For students this is confusing, since the might overwrite the references, so there needs to be an option to disable it. Disabling it by default is a bit randomly chosen, but having less code in the student version of the code is the idea.


📚 Documentation preview 📚: https://scicode-widgets--44.org.readthedocs.build/en/44/

@agoscinski agoscinski force-pushed the remove-all-references-button branch from 39d6c78 to ff4b797 Compare December 21, 2024 09:57
@agoscinski agoscinski marked this pull request as ready for review December 21, 2024 09:58
…try` by default

This button is only meant for teachers so it should be able to disable
it. For that we add the property `display_set_all_references_button` that
can be given on initilization or setted after. We also change the order
of the buttons so the `Check all widgets` button does not change its
position between enabling and disabling this option.
@agoscinski agoscinski force-pushed the remove-all-references-button branch from ff4b797 to 7a90d7e Compare December 21, 2024 10:14
@agoscinski agoscinski merged commit bd4fff7 into main Dec 21, 2024
2 of 3 checks passed
@agoscinski agoscinski deleted the remove-all-references-button branch December 21, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant