Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nested errors are not correctly resolved #62

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Sep 23, 2024

When an exception is thrown within a WCI, the last frame is used as context to add the input lines. This does not work if the exception is thrown within a function within WCI. Therefore we now iterate through all traceback frames to find the one corresponding to WCI.

The corresponding PR in WCI osscar-org/widget-code-input#26 to solve it there.


📚 Documentation preview 📚: https://scicode-widgets--62.org.readthedocs.build/en/62/

When an exception is thrown within a WCI, the last frame is used as
context to add the input lines. This does not work if the exception is
thrown within a function within WCI. Therefore we now iterate through
all traceback frames to find the one corresponding to WCI.

The corresponding PR in WCI osscar-org/widget-code-input#26
to solve it there.
@agoscinski agoscinski merged commit 3e7c112 into main Sep 24, 2024
3 checks passed
@agoscinski agoscinski deleted the fix-nested-errors branch September 24, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant