Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the remove in test_save_registry in try-finally block #83

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Nov 29, 2024

In case the tests fail after the creation of the file but before the remove, the file still is not removed and will make the test fail in the next run.


📚 Documentation preview 📚: https://scicode-widgets--83.org.readthedocs.build/en/83/

@agoscinski agoscinski changed the title Put the remove in test test_save_registry in try-finally block Put the remove in test_save_registry in try-finally block Nov 29, 2024
In case the tests fail after the creation of the file but before the
remove, the file still is not removed and will make the test fail in the
next run.
@agoscinski agoscinski merged commit eec8088 into main Dec 21, 2024
2 of 3 checks passed
@agoscinski agoscinski deleted the try-finally-rm branch December 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant